Fixing potential globbing matching in condition

https://github.com/koalaman/shellcheck/wiki/SC2053
4 years ago · 77613a34a4
parent 18164abc73
commit 77613a34a4
1 changed files with 1 additions and 1 deletions
--- a/cloudflare-template.sh
+++ b/cloudflare-template.sh
@ -48,7 +48,7 @@ fi
 ###########################################
 old_ip=$(echo "$record" | grep -Po '(?<="content":")[^"]*' | head -1)
 # Compare if they're the same
-if [[ $ip == $old_ip ]]; then
+if [[ $ip == "${old_ip}" ]]; then
  logger "DDNS Updater: IP ($ip) for ${record_name} has not changed."
  exit 0
 fi